[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1021) Don't log exceptions if they are handled in pages.xml

[Andrew (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBSEAM-1021?page=comments#action_12369967 ] 
            
Andrew commented on JBSEAM-1021:
--------------------------------

Yes, please remove the log.error call from the SeamPhaseListener beforePhase catch block. Since exceptions are expected (NotLoggedInException for example), those should not be logged as errors, but rather as debug level probably. Any chance as separating this error handling so that expected exceptions are not logged as errors?

> Don't log exceptions if they are handled in pages.xml
> -----------------------------------------------------
>
>                 Key: JBSEAM-1021
>                 URL: http://jira.jboss.com/jira/browse/JBSEAM-1021
>             Project: JBoss Seam
>          Issue Type: Bug
>          Components: Security
>            Reporter: Christian Bauer
>         Assigned To: Gavin King
>            Priority: Minor
>
> Mostly relevant for security:
> 01:54:16,042 ERROR [SeamPhaseListener] uncaught exception
> javax.faces.el.EvaluationException: Exception while invoking expression #{documentHome.checkNodePermission}
> ...
> You get hundreds of these when you run a site with security. Didn't find an open JIRA case for that.
> I think the SeamPhaseListener should not log.error() "uncaught exception" and print the whole thing _and_ pass it on to Exceptions.instance().handle(e). The phase listener doesn't know if it's handled or not.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira