[jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-1324) javascript error in IE6 when remote call does not render anything to response.

[Shane Bryzak (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBSEAM-1324?page=all ]

Shane Bryzak closed JBSEAM-1324.
--------------------------------

    Fix Version/s: 1.3.0.ALPHA
       Resolution: Done

I've added this extra check in CVS, thanks for the patch.

> javascript error in IE6 when remote call does not render anything to response.
> ------------------------------------------------------------------------------
>
>                 Key: JBSEAM-1324
>                 URL: http://jira.jboss.com/jira/browse/JBSEAM-1324
>             Project: JBoss Seam
>          Issue Type: Bug
>          Components: Remoting
>            Reporter: Keith Naas
>         Assigned To: Shane Bryzak
>             Fix For: 1.3.0.ALPHA
>
>
> If an exception occurs in the remote call, it is caught by the ExecutionHandler, logged, and the request is ended.  Since nothing is written to the response, the document is empty.  In IE6 this causes a javascript error.
> Something like this should get rid of the problem.
> ### Eclipse Workspace Patch 1.0
> #P jboss-seam
> Index: src/remoting/org/jboss/seam/remoting/remote.js
> ===================================================================
> RCS file: /cvsroot/jboss/jboss-seam/src/remoting/org/jboss/seam/remoting/remote.js,v
> retrieving revision 1.3
> diff -u -r1.3 remote.js
> --- src/remoting/org/jboss/seam/remoting/remote.js	1 May 2007 00:08:12 -0000	1.3
> +++ src/remoting/org/jboss/seam/remoting/remote.js	15 May 2007 14:39:58 -0000
> @@ -624,13 +624,16 @@
>    var bodyNode;
>    var context = new Seam.Remoting.__Context;
>  
> -  for (var i = 0; i < doc.documentElement.childNodes.length; i++)
> +  if (doc.documentElement)
>    {
> -    var node = doc.documentElement.childNodes.item(i);
> -    if (node.tagName == "header")
> -      headerNode = node;
> -    else if (node.tagName == "body")
> -      bodyNode = node;
> +    for (var i = 0; i < doc.documentElement.childNodes.length; i++)
> +    {
> +      var node = doc.documentElement.childNodes.item(i);
> +      if (node.tagName == "header")
> +        headerNode = node;
> +      else if (node.tagName == "body")
> +        bodyNode = node;
> +    }
>    }
>  
>    if (headerNode)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira