[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1099) s:button does not show both image and text

[Chris Wash (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBSEAM-1099?page=comments#action_12357173 ] 
            
Chris Wash commented on JBSEAM-1099:
------------------------------------

I went digging into FishEye to investigate this issue and it looks like it should work.  Unfortunately I'm behind a proxy here and can't check the project out to test.  Looks like a quick hit, writeStart should handle output of the type image and src, while writeEnd should render the label.

Not sure where this is with regards to the CDK port.  I'll try to test from home this weekend.

http://fisheye.labs.jboss.com/browse/JBoss/jboss-seam/seam-ui-cdk/jboss-seam-ui/src/main/java/org/jboss/seam/ui/renderkit/ButtonRendererBase.java

   @Override
   public void writeStart(ResponseWriter writer, FacesContext facesContext,
            UISeamCommandBase seamCommand) throws IOException
   {
      
      UIButton button = (UIButton) seamCommand;
      writer.startElement("input", seamCommand);

      if (button.getImage() == null) {
          writer.writeAttribute("type", "button", null);
      } else {
          writer.writeAttribute("type", "image", null);
          writer.writeAttribute("src", button.getImage(), null);
      }
      
      if ( seamCommand.disabled() ) writer.writeAttribute("disabled", true, "disabled");

   }

   @Override
   public void writeEnd(ResponseWriter writer, FacesContext facesContext,
            UISeamCommandBase seamCommand) throws IOException
   {
      Object label = seamCommand.getValue();
      if (label!=null) 
      {
         writer.writeAttribute("value", label, "label");
      }
   }

> s:button does not show both image and text
> ------------------------------------------
>
>                 Key: JBSEAM-1099
>                 URL: http://jira.jboss.com/jira/browse/JBSEAM-1099
>             Project: JBoss Seam
>          Issue Type: Bug
>          Components: JSF
>    Affects Versions: 1.2.0.GA
>            Reporter: Alex Narinsky
>
> I need to create a button that shows both text and image.  I found that if I use s:button then after image specification the text does not show up.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira