[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1243) Ending nested conversation causes issues with pages.xml and rendering the same view again

[Andrew (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBSEAM-1243?page=comments#action_12361186 ] 
            
Andrew commented on JBSEAM-1243:
--------------------------------

Code from Manager.java in CVS:

739:   public void endConversation(boolean beforeRedirect)
740:   {
741:      log.debug("Ending long-running conversation");
742:      if ( Events.exists() ) Events.instance().raiseEvent("org.jboss.seam.endConversation");
743:      setLongRunningConversation(false);
744:      destroyBeforeRedirect = beforeRedirect;
745:      endNestedConversations( getCurrentConversationId() );
746:      storeConversationToViewRootIfNecessary();
747:   }

The problem is from line 743. It never checks to see if the conversation it is ending is a nested conversation. It always sets that there is no conversation. 

Perhaps it should be:

743:      setLongRunningConversation(!isNestedConversation());

And then somewhere on a new line after this, the parent conversation should be restored I think.


> Ending nested conversation causes issues with pages.xml and rendering the same view again
> -----------------------------------------------------------------------------------------
>
>                 Key: JBSEAM-1243
>                 URL: http://jira.jboss.com/jira/browse/JBSEAM-1243
>             Project: JBoss Seam
>          Issue Type: Bug
>    Affects Versions: 1.1.6.GA
>            Reporter: Andrew
>         Assigned To: Gavin King
>             Fix For: 1.3.0.BETA1
>
>         Attachments: JBSEAM-1243.zip
>
>
> See JBoss Forum Reference of this bug.
> Will try to attach reproduce code in a bit.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira