[jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-1363) ManagedPersistenceContext.getEntityManager() should not throw NamingException

[Gavin King (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBSEAM-1363?page=all ]

Gavin King closed JBSEAM-1363.
------------------------------

    Resolution: Rejected

A generic, unknown failure accessing the naming service is definitely not the same thing as there being no transaction. I don't want to change this.

Exceptions thrown out of @Unwrap methods get wrapped in RuntimeExceptions, and can be handled in pages.xml.

> ManagedPersistenceContext.getEntityManager() should not throw NamingException
> -----------------------------------------------------------------------------
>
>                 Key: JBSEAM-1363
>                 URL: http://jira.jboss.com/jira/browse/JBSEAM-1363
>             Project: JBoss Seam
>          Issue Type: Bug
>    Affects Versions: 1.2.1.GA
>            Reporter: Michael Youngstrom
>             Fix For: 1.3.0.ALPHA
>
>
> ManagedPersistenceContext.getEntityManager() has the potential to throw a NamingException because of a call to Transactions.isTransactionActive().  I believe ManagedPersistenceContext.getEntityManager() should assume that a NamingException thrown from Transactions.isTransactionActive() equates to "false".
> My guess is the "throws NamingException" might be a relic of obtaining an EntityMangager from an EMF obtained through JNDI.  However, that has moved to initEntityManager() that handles the error of obtaining an EMF on it's own.  So, I think getEntityManager should log a NamingException thrown from Transactions.isTransactionActive() and move on as if no transaction is active.
> Mike

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira