[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1969) updatedMessage, deletedMessage and createdMessage in framework.Home cause NPE if getEntityClass is overridden

[Pete Muir (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBSEAM-1969?page=comments#action_12380222 ] 
            
Pete Muir commented on JBSEAM-1969:
-----------------------------------

1. Yes, this is what the bug is all about and the patch fixes

2. How is this.id used all over the place in Home?  I see it used in 3 places: assignId, setId and getId.  All of which are completely correct and allow overriding of getId. No, we certainly shouldn't make getId final.

A large point of the framework is to allow you to use it as a base overriding where necessary *including* getId() (the ref docs even show doing this).

And yes, if you override getId you are of course responsible for dirty checking on the field.

> updatedMessage, deletedMessage and createdMessage in framework.Home cause NPE if getEntityClass is overridden
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: JBSEAM-1969
>                 URL: http://jira.jboss.com/jira/browse/JBSEAM-1969
>             Project: JBoss Seam
>          Issue Type: Bug
>          Components: Framework
>         Environment: Mac OSX 10.4.8, Jboss 4.2.1, Seam 1.3.0 
>            Reporter: Damian Harvey
>         Assigned To: Dan Allen
>            Priority: Trivial
>             Fix For: 2.0.1.GA
>
>         Attachments: HomeTest.java, JBSEAM-1969-v1.txt, SimpleEntity.java
>
>
> I am extending an existing class (BookingHome) that extends EntityHome. My BookingHome class needs to override getEntityClass. Doing this then results in a NPE as updatedMessage, deletedMessage and createdMessage refer to entityClass rather than getEntityClass.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira