[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2038) Documentation of xml namespace component configuration not consistent with example

Matt Drees (JIRA) jira-events at lists.jboss.org
Thu Oct 4 11:41:40 EDT 2007


    [ http://jira.jboss.com/jira/browse/JBSEAM-2038?page=comments#action_12380503 ] 
            
Matt Drees commented on JBSEAM-2038:
------------------------------------

I wonder if the following code from Initialization.java line 247ish is wrong:

            //finally, if we could not get the name from the XML name attribute,
            //or from an @Name annotation on the class, imply it
            if (name == null)
            {
               String prefix = nsInfo.getNamespace().prefix();
               name = Strings.isEmpty(prefix) ? 
                     elemName : prefix + '.' + elemName;
            }

The name it comes up with is not a sensible one, because elemName is capitalized (it was used earlier to look for a class).  So, for the first example above, it would produce "PaymentHome", not "paymentHome".

If this were corrected, the SeamPay example might be able to drop the name="paymentHome" attribute.
If I had more free time, I'd test it, but I should be spending more time on my project as it is.

> Documentation of xml namespace component configuration not consistent with example
> ----------------------------------------------------------------------------------
>
>                 Key: JBSEAM-2038
>                 URL: http://jira.jboss.com/jira/browse/JBSEAM-2038
>             Project: JBoss Seam
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 2.0.0.CR1
>            Reporter: Matt Drees
>            Priority: Minor
>             Fix For: 2.0.0.GA
>
>
> As an example of a component that can be configured in components.xml, the documentation has:
>     <pay:payment-home new-instance="#{newPayment}"
>                       created-message="Created a new payment to #{newPayment.payee}" />
> However, the SeamPay example has:
>     <pay:payment-home name="paymentHome" 
>                       new-instance="#{newPayment}" 
>                       created-message="Created a new payment to #{newPayment.payee}" />
> I think I tried it once a few months ago, and the the first doesn't work.  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        



More information about the seam-issues mailing list