[jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-2173) enableFilter: for ( Map.Entry<String, ValueExpression> me: f.getParameters().entrySet() ) throws NPE if there're no parameters

[jarkko Lietolahti (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBSEAM-2173?page=all ]

jarkko Lietolahti updated JBSEAM-2173:
--------------------------------------

    Description: 
In components.xml
	<core:filter name="deletedFilter">
		<core:name>deletedFilter</core:name>
	</core:filter>

will cause NPE in  f.getParameters().entrySet()

HibernatePersistenceProvider:
 @Override
   public void enableFilter(Filter f, EntityManager entityManager)
   {
      try
      {
         org.hibernate.Filter filter = getSession(entityManager).enableFilter( f.getName() );
         for ( Map.Entry<String, ValueExpression> me: f.getParameters().entrySet() )
         {
            filter.setParameter( me.getKey(), me.getValue().getValue() );
         }
         filter.validate();
      }
      catch (NotHibernateException nhe)
      {
         super.enableFilter(f, entityManager);
      }

   }

  was:
HibernatePersistenceProvider:
 @Override
   public void enableFilter(Filter f, EntityManager entityManager)
   {
      try
      {
         org.hibernate.Filter filter = getSession(entityManager).enableFilter( f.getName() );
         for ( Map.Entry<String, ValueExpression> me: f.getParameters().entrySet() )
         {
            filter.setParameter( me.getKey(), me.getValue().getValue() );
         }
         filter.validate();
      }
      catch (NotHibernateException nhe)
      {
         super.enableFilter(f, entityManager);
      }

   }


> enableFilter: for ( Map.Entry<String, ValueExpression> me: f.getParameters().entrySet() ) throws NPE if there're no parameters
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBSEAM-2173
>                 URL: http://jira.jboss.com/jira/browse/JBSEAM-2173
>             Project: JBoss Seam
>          Issue Type: Bug
>          Components: Core
>            Reporter: jarkko Lietolahti
>             Fix For: 1.2.1.GA
>
>
> In components.xml
> 	<core:filter name="deletedFilter">
> 		<core:name>deletedFilter</core:name>
> 	</core:filter>
> will cause NPE in  f.getParameters().entrySet()
> HibernatePersistenceProvider:
>  @Override
>    public void enableFilter(Filter f, EntityManager entityManager)
>    {
>       try
>       {
>          org.hibernate.Filter filter = getSession(entityManager).enableFilter( f.getName() );
>          for ( Map.Entry<String, ValueExpression> me: f.getParameters().entrySet() )
>          {
>             filter.setParameter( me.getKey(), me.getValue().getValue() );
>          }
>          filter.validate();
>       }
>       catch (NotHibernateException nhe)
>       {
>          super.enableFilter(f, entityManager);
>       }
>    }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira