[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3251) ValidateAllRendererBase not robust enough for dynamic components

[Pete Muir (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBSEAM-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12424363#action_12424363 ] 

Pete Muir commented on JBSEAM-3251:
-----------------------------------

(1) sounds like it could be a bug.

(2) s:validateAll attaches a default validator only, so the behaviour is correct

> ValidateAllRendererBase not robust enough for dynamic components
> ----------------------------------------------------------------
>
>                 Key: JBSEAM-3251
>                 URL: https://jira.jboss.org/jira/browse/JBSEAM-3251
>             Project: Seam
>          Issue Type: Bug
>          Components: JSF Controls
>    Affects Versions: 2.0.2.SP1, 2.0.3.CR1, 2.1.0.A1
>         Environment: Any
>            Reporter: Richard Kennard
>            Priority: Minor
>         Attachments: ValidateAllRendererBase.java
>
>   Original Estimate: 30 minutes
>  Remaining Estimate: 30 minutes
>
> org.jboss.seam.ui.renderkit.ValidateAllRendererBase has two minor problems (with easy fixes) that stop it working with highly dynamic components:
> 1. doEncodeChildren attaches its ModelValidators before calling renderChildren. This misses any subcomponents the children may themselves dynamically create during their encodeBegin phase. Moving renderChildren down fixes this
> 2. A ModelValidator is only attached if the component has no existing Validators. This seems a bit of a blunt instrument. Presumably the idea is to stop attaching multiple ModelValidators. If the component happens to have, say, a LengthValidator that shouldn't stop ModelValidator entirely.
> I have attached an updated ValidateAllRendererBase. It does not break any existing unit tests.
> Disclaimer: my vested interest in this is because of Metawidget (http://www.metawidget.org).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira