[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2619) Appended conversation id in UILoadStyle prevents caching of dynamically included CSS

[Christian Bauer (JIRA)]

Appended conversation id in UILoadStyle prevents caching of dynamically included CSS
------------------------------------------------------------------------------------

                 Key: JBSEAM-2619
                 URL: http://jira.jboss.com/jira/browse/JBSEAM-2619
             Project: JBoss Seam
          Issue Type: Bug
          Components: JSF Integration
    Affects Versions: 2.1.0.A1
            Reporter: Christian Bauer
            Priority: Minor


The UILoadStyle component adds <link>s to custom CSS files to a page header, served by the resource servlet:

<link rel='stylesheet'  type='text/css' href='/wiki/seam/resource/style/themes/inrelationto/css/faqBrowser.css?cid=20' />

The appended conversation id prevents caching in browsers of this resource, it is set here:

public abstract class UILoadStyle extends HtmlLoadStyle
{

   @Override
   public Object getSrc()
   {

      UIConversationId uiConversationId = UIConversationId.newInstance();
      uiConversationId.setViewId(Pages.getViewId(getFacesContext()));
      try
      {
         UrlBuilder urlBuilder = new UrlBuilder(StyleResource.WEB_RESOURCE_PATH + super.getSrc(), null, FacesContext.getCurrentInstance().getResponseWriter().getCharacterEncoding());
         urlBuilder.addParameter(uiConversationId);

I can see that we might want to stay inside the conversation sometimes, especially because the whole point of serving CSS through the resources infrastructure is to parse EL in these CSS files. So the best action would probably be an option on the UILoadStyle component that disables conversation propagation.



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira