[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2697) Add attribute to s:link tag to make creation of magic dataModelSelection URL parameter optional

Fri Feb 29 22:02:57 EST 2008

Add attribute to s:link tag to make creation of magic dataModelSelection URL parameter optional
-----------------------------------------------------------------------------------------------

                 Key: JBSEAM-2697
                 URL: http://jira.jboss.com/jira/browse/JBSEAM-2697
             Project: JBoss Seam
          Issue Type: Feature Request
          Components: JSF Controls
    Affects Versions: 2.0.1.GA
            Reporter: Wolfgang Schwendt
            Priority: Minor

When an s:link component (org.jboss.seam.ui.component.UILink) is placed into a h:dataTable backed by a javax.faces.model.DataModel,  the s:link automatically generates the magic token for the magic "dataModelSelection" parameter regardless of whether the latter is really needed or not.

This can generate ugly URLs.    The following example is particulary ugly:

http://127.0.0.1:8080/seminaris/seminarDetails.seam?seminarId=2&dataModelSelection=sem%3AzumSeminarAnmelden_szSeminarSuchen_seminarListeDataModel%5B1%5D&actionMethod=zumSeminarAnmelden%2FseminarSuchen.xhtml%3AzumSeminarAnmelden_seminarBuchenAction.selectSeminar

Without the "dataModelSelection" parameter, the URL would look much cleaner:

http://127.0.0.1:8080/seminaris/seminarDetails.seam?semId=2

So my question:   Couldn't we make the "dataModelSelection" parameter optional? (For example, by adding an attribute to the s:link tag).

Btw:  I'm aware that  org.jboss.seam.ui.component.UISeamCommandBase.getUrl() is the culprit that triggers inclusion of the the dataModelSelection parameter, so I know how to remove the dataModelSelection parameter generation, but it would be nice if also the officially released Seam version allowed the deactivation of the magic token generation.

Further, no magic token is generated if a UIDataTable is supplied by a normal List rather than a DataModel (cf. UISeamCommandBase.getSelection() ), but unfortunately there can be cases where it makes sense to supply the table data as DataModel rather than normal List.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira