[jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-3058) HTML and CSS sanitation filters for Seam Text

Mon Jun 2 08:41:20 EDT 2008

     [ http://jira.jboss.com/jira/browse/JBSEAM-3058?page=all ]

Christian Bauer closed JBSEAM-3058.
-----------------------------------

    Fix Version/s: 2.1.0.GA
       Resolution: Done

Backported the SeamTextParser.Sanitizer to 2.0.x, implication is that certain style=".." values in plain HTML elements might no longer work.

> HTML and CSS sanitation filters for Seam Text
> ---------------------------------------------
>
>                 Key: JBSEAM-3058
>                 URL: http://jira.jboss.com/jira/browse/JBSEAM-3058
>             Project: Seam
>          Issue Type: Task
>          Components: Wiki, Seam Text
>            Reporter: Christian Bauer
>         Assigned To: Christian Bauer
>            Priority: Blocker
>             Fix For: 2.0.x, 2.1.0.GA
>
>
> Although we only allow certain elments and attributes, and do not allow quotes and ampersands in HTML fragments parsed through Seam Text, various XSS attack vectors are still open. 
> 1. We can't remove IMG and A from the allowed list of HTML elements because they are already used in probably hundreds of documents. So we need to filter the SRC and HREF attribute values.
> 2. We need to filter the STYLE attribute on any element, because a) background:url(javascript) is executed on most browser b) Internet Explorer also executes background-color: expression(javascript). But, the STYLE attribute it is used for document layout on production sites (mostly with DIV elements) and there simply is no alternative.
> The following rules from the Ruby/Python rules can be a starting point: http://wiki.whatwg.org/wiki/Sanitization_rules
> First, implement the callbacks/stacks in seam-text.g so this filter can be hooked in as a SeamTextParser extension.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira