[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3055) UISeamCommandBase adds conversation request parameters when not needed

Fri May 30 05:10:45 EDT 2008

    [ http://jira.jboss.com/jira/browse/JBSEAM-3055?page=comments#action_12414966 ] 

Christian Bauer commented on JBSEAM-3055:
-----------------------------------------

I don't think 2. makes sense either. If I use <s:link view="/foo.xhtml" propagation="end"/> and, at the time the link is rendered the current conversation is temporary, we would indeed not need the propagation parameter to be appended. However, if the conversation is promoted shortly after the link has been rendered (remember: any value expression can call a method or factory annotated @Begin), we absolutely need to render the propagation rule. Because we want the conversation to be demoted (end) when the NEXT request cycle completes. This is really the same issue as in 1. 

> UISeamCommandBase adds conversation request parameters when not needed
> ----------------------------------------------------------------------
>
>                 Key: JBSEAM-3055
>                 URL: http://jira.jboss.com/jira/browse/JBSEAM-3055
>             Project: Seam
>          Issue Type: Bug
>          Components: JSF Controls
>    Affects Versions: 2.1.0.A1, 2.0.2.SP1
>            Reporter: Dan Allen
>            Priority: Minor
>             Fix For: 2.1.0.GA
>
>   Original Estimate: 2 hours
>  Remaining Estimate: 2 hours
>
> The base class for s:link and s:button, UISeamCommandBase, is not very smart about the conversation id and propagation parameters, adding them even when they have no purpose.
> Here are the two correct behaviors that are being violated:
> - conversation id parameter shouldn't be appended if conversation is temporary (no conversation to pass on)
> - conversation propagation parameter shouldn't be appended if its value is "end" and the conversation is temporary (no conversation to end)
> To ensure theses parameters aren't appended, folks are having to append propagation="none" all over the place. While on the one hand, this is just an annoyance, it really throws a wrench into urlrewriting. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira