[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3053) Natural conversation id initialized at wrong time, leading to exceptions

[Dan Allen (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBSEAM-3053?page=comments#action_12415034 ] 
            
Dan Allen commented on JBSEAM-3053:
-----------------------------------

>From my perspective, it address that other problem too. You stated:

"currently, it's not able to build the natural conversation id, so gives it a synthetic ID"

That's only because the logic inside of the natural conversation id class was:

String id = getRequestConversationId(parameters);
return id==null ? Id.nextId() : id;

Which is clearly the source of the problem in this case. It was knowingly generating a synthetic ID. Now the logic takes this opportunity to generate a natural conversation id

return id == null ? getConversationId() : id;

Where getConversationId() evaluates the EL expression. The screwy part before was that the natural conversation id class was calling the synthetic id generator.

> Natural conversation id initialized at wrong time, leading to exceptions
> ------------------------------------------------------------------------
>
>                 Key: JBSEAM-3053
>                 URL: http://jira.jboss.com/jira/browse/JBSEAM-3053
>             Project: Seam
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.1.0.A1, 2.0.2.SP1
>            Reporter: Dan Allen
>         Assigned To: Dan Allen
>             Fix For: 2.0.x, 2.1.0.BETA1
>
>         Attachments: JBSEAM-3053-branch_20-v1.txt, JBSEAM-3053-trunk-v1.txt
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> When there is a request to use a natural conversation, and the conversation id is not part of the request, the natural value (EL) is being resolved prior to the temporary conversation being initialized, potentially leading to exceptions. The natural value should be resolved when the conversation id provider is asked to initialize a value.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira