[jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-3609) Performance problem: when using <s:link> or <s:button> with page.xml

[Shane Bryzak (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBSEAM-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shane Bryzak closed JBSEAM-3609.
--------------------------------

    Resolution: Done


I've committed some changes to SVN that should address this issue now, I'd appreciate it if someone could give it some thorough testing and report back here if you encounter any issues.

There is now a new attribute, includePageParams available on both the s:button and s:link controls.  Likewise, the <redirect> element in pages.xml also supports a new attribute called "include-page-params".  By default, this attribute is true to preserve backwards compatibility.  When set to true, individual page parameters can be suppressed in the button or link by specifying a null value, either like this:

<s:link view-id="/foo.xhtml">
  <f:param name="suppressedParameter" value="#{null}"/>
</s:link>

or like this:

<s:link view-id="/foo.xhtml">
  <f:param name="suppressedParameter"/>
</s:link>

This was already the default behaviour, and this same behaviour has been preserved with this change.

When setting includePageParams to false, any page parameters defined in pages.xml will be excluded from the rendered button or link.  For example, the following link:

<s:link view-id="/foo.xhtml" includePageParams="false"/>

will exclude any page parameters defined in pages.xml.  Of course it is still possible to manually specify a different parameter value if required.

> Performance problem: when using <s:link> or <s:button> with page.xml
> --------------------------------------------------------------------
>
>                 Key: JBSEAM-3609
>                 URL: https://jira.jboss.org/jira/browse/JBSEAM-3609
>             Project: Seam
>          Issue Type: Bug
>    Affects Versions: 2.0.2.SP1, 2.0.3.CR1
>         Environment: JDK 1.5.0_14, jboss-4.2.3.GA
>            Reporter: Kenneth Zhang
>            Assignee: Shane Bryzak
>            Priority: Critical
>             Fix For: 2.1.1.CR1
>
>         Attachments: Book-sample.zip, screenshot-1.jpg
>
>
> <s:link> or <s:button> will automatically check the View_id's page.xml, and temporary construct the seam components in the page.xml, then call component's @Create and @Destroy method.
> For example:
> There is a <s:link> at the menu.xhtml:
>     <s:link view="/login.xhtml" value="Login"/>
> If login.page.xhtml like this:
>     <param name="order" value="#{deptList.order}"/>
> seam will automatically construct the deptList component, and call it's @Create and @Destroy method.
> I find the issue at Seam 2.0.2.SP1 and 2.0.3.CR1.
> It's a big performance problem, please resolve it ASAP.
> Thanks a lot and sorry for my bad english.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira