[jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-3500) Close streams loaded in Resources and log files loaded.

[Norman Richards (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBSEAM-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Norman Richards closed JBSEAM-3500.
-----------------------------------

    Resolution: Done


Done.  

> Close streams loaded in Resources and log files loaded.
> -------------------------------------------------------
>
>                 Key: JBSEAM-3500
>                 URL: https://jira.jboss.org/jira/browse/JBSEAM-3500
>             Project: Seam
>          Issue Type: Bug
>            Reporter: Pete Muir
>            Assignee: Norman Richards
>             Fix For: 2.1.0.GA
>
>
> Adrian Brock wrote:
> > On a related note, somebody needs to review these classes 
> > http://fisheye.jboss.com/browse/Seam/trunk/src/main/org/jboss/seam/util/Resources.java 
> > http://fisheye.jboss.com/browse/Seam/trunk/src/main/org/jboss/seam/init/Initialization.java
> > 
> > 1) Any stream that gets opened should not be left to the garbage collector to close. That is a waste of resources and slows done any GC.
> > 
> > 2) The method should have some debug logging so you can easily tell where it is loading the files from (if at all) 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira