[jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3658) Wicket components with children that don't implement virtual methods fail to instrument

[Clint Popetz (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBSEAM-3658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Clint Popetz updated JBSEAM-3658:
---------------------------------

    Description: 
Because the instrumentor makes the preamble lookup its own method with getClass().getDeclaredMethod, it creates broken instrumentations of:

class base { 
 void method foo(); 
}

class subclass extends base {  }

because foo's preamble will get base as its Class object, which has no declared foo().  The preamble with the attached patch is now generated as:

base.class.getDeclaredMethod(...)

rather than

getClass().getDeclaredMethod()

This was exposed in the wicket booking example because SimpleDataProvider was not previously instrumented, as it was abstract, but https://jira.jboss.org/jira/browse/JBSEAM-3594 caused us to start instrumenting abstract classes.

  was:
Because the instrumentor makes the preamble loup its own method with getClass().getDeclaredMethod, it creates broken instrumentations of:

class base { 
 void method foo(); 
}

class subclass extends base {  }

because foo's preamble will get base as its Class object, which has no declared foo().  The preamble with the attached patch is now generated as:

base.class.getDeclaredMethod(...)

rather than

getClass().getDeclaredMethod()

This was exposed in the wicket booking example because SimpleDataProvider was not previously instrumented, as it was abstract, but https://jira.jboss.org/jira/browse/JBSEAM-3594 caused us to start instrumenting abstract classes.



> Wicket components with children that don't implement virtual methods fail to instrument
> ---------------------------------------------------------------------------------------
>
>                 Key: JBSEAM-3658
>                 URL: https://jira.jboss.org/jira/browse/JBSEAM-3658
>             Project: Seam
>          Issue Type: Bug
>            Reporter: Clint Popetz
>         Attachments: seam-patch-for-missing-inherited-methods.diff
>
>
> Because the instrumentor makes the preamble lookup its own method with getClass().getDeclaredMethod, it creates broken instrumentations of:
> class base { 
>  void method foo(); 
> }
> class subclass extends base {  }
> because foo's preamble will get base as its Class object, which has no declared foo().  The preamble with the attached patch is now generated as:
> base.class.getDeclaredMethod(...)
> rather than
> getClass().getDeclaredMethod()
> This was exposed in the wicket booking example because SimpleDataProvider was not previously instrumented, as it was abstract, but https://jira.jboss.org/jira/browse/JBSEAM-3594 caused us to start instrumenting abstract classes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira