[jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-1747) SeamPhaseListener transaction debug log statements are misleading/confusing

[Pete Muir (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBSEAM-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Muir closed JBSEAM-1747.
-----------------------------

    Resolution: Done
      Assignee: Pete Muir


It now looks like

2008-09-03 19:24:49,581 DEBUG [org.jboss.seam.jsf.SeamPhaseListener] beginning transaction prior to phase: RESTORE_VIEW 1
2008-09-03 19:24:49,653 DEBUG [org.jboss.seam.jsf.SeamPhaseListener] committing transaction after phase: PROCESS_VALIDATIONS 3
2008-09-03 19:24:49,655 DEBUG [org.jboss.seam.jsf.SeamPhaseListener] beginning transaction prior to phase: RENDER_RESPONSE 6
2008-09-03 19:24:49,682 DEBUG [org.jboss.seam.jsf.SeamPhaseListener] committing transaction after invoking page actions
2008-09-03 19:24:49,684 DEBUG [org.jboss.seam.jsf.SeamPhaseListener] beginning transaction before continuing render
2008-09-03 19:24:49,742 DEBUG [org.jboss.seam.jsf.SeamPhaseListener] committing transaction after phase: RENDER_RESPONSE 6


> SeamPhaseListener transaction debug log statements are misleading/confusing
> ---------------------------------------------------------------------------
>
>                 Key: JBSEAM-1747
>                 URL: https://jira.jboss.org/jira/browse/JBSEAM-1747
>             Project: Seam
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0.BETA1
>         Environment: 20070727.1142
>            Reporter: Matt Drees
>            Assignee: Pete Muir
>            Priority: Trivial
>             Fix For: 2.1.0.CR1
>
>
> Debug logs from SeamPhaseListener look something like this on a non-faces request:
> DEBUG 31-07 11:34:31,467 (org.jboss.seam.jsf.SeamPhaseListener:begin:573) beginning transaction prior to phase: RESTORE_VIEW 1
> DEBUG 31-07 11:34:31,560 (org.jboss.seam.jsf.SeamPhaseListener:commitOrRollback:589) committing transaction after phase: RESTORE_VIEW 1
> DEBUG 31-07 11:34:31,560 (org.jboss.seam.jsf.SeamPhaseListener:begin:573) beginning transaction prior to phase: RENDER_RESPONSE 6
> DEBUG 31-07 11:34:31,576 (org.jboss.seam.jsf.SeamPhaseListener:commitOrRollback:589) committing transaction after phase: INVOKE_APPLICATION 5
> DEBUG 31-07 11:34:31,592 (org.jboss.seam.jsf.SeamPhaseListener:begin:573) beginning transaction prior to phase: INVOKE_APPLICATION 5
> DEBUG 31-07 11:34:33,731 (org.jboss.seam.jsf.SeamPhaseListener:commitOrRollback:589) committing transaction after phase: RENDER_RESPONSE 6
> It's misleading.  For one thing, there is no "INVOKE_APPLICATION" phase; but that phaseid is used for logging before and after page actions.  For another, the "before" and "after" statements are backwards (semantically).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira