[jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-3382) New caching providers functionality is seriously broken (PATCH)

[Pete Muir (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBSEAM-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Muir closed JBSEAM-3382.
-----------------------------

    Fix Version/s: 2.1.0.CR1
       Resolution: Done
         Assignee: Pete Muir


I applied your patches with a couple of alterations (don't adjust precedence to FRAMEWORK - this was wrong in another cache provider to, don't increase logging level, adjust API for get(String key, String region) to get(String region, String key))

Please test for me :-) Thanks

> New caching providers functionality is seriously broken (PATCH)
> ---------------------------------------------------------------
>
>                 Key: JBSEAM-3382
>                 URL: https://jira.jboss.org/jira/browse/JBSEAM-3382
>             Project: Seam
>          Issue Type: Bug
>    Affects Versions: 2.1.0.BETA1
>         Environment: Seam 2.1 build 300
>            Reporter: Przemyslaw Jaskierski
>            Assignee: Pete Muir
>             Fix For: 2.1.0.CR1
>
>         Attachments: CacheRendererBase.java.diff.txt, EhCacheProvider.java.diff.txt
>
>
> I tried to use EhCacheProvider and hit (too) many problems (not only in EhCache implementation). My changes make caching usable again and everything works fine:
> 1. CacheRenderBase
> Cache region and key argument have been written in the wrong order. So every cache provider received cache region name as a key an vice versa. I'm not sure if this code is generated by CDK, if not you can use my CacheRendererBase.java.diff.txt patch. Additionally this class can be cleared of unused variable and imports (skipped for readability sake).
> 2. EhCacheProvider
> This component had wrong scope (STATELESS). I've changed it to APPLICATION. In original implementation it was throwing NPE because @Create initialization wasn't invoked even once. Moreover killing user with ISException in case of non existing region is too harsh - ehcache has defaults which can be defined. Look at my proposal in EhCacheProvider.java.diff.txt.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira