[jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-3408) Define available @UserPassword hash constants as an enumeration

[Shane Bryzak (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBSEAM-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shane Bryzak closed JBSEAM-3408.
--------------------------------

    Resolution: Won't Fix
      Assignee: Shane Bryzak


The problem with doing that, is that there are many other hash algorithms which we don't implement, and the PasswordHash class was specifically implemented as a Seam component so that it would be possible to extend it to support other algorithms.  I will improve the documentation in this area though, I didn't realise that I'd forgotten to include the "none" value.

> Define available @UserPassword hash constants as an enumeration
> ---------------------------------------------------------------
>
>                 Key: JBSEAM-3408
>                 URL: https://jira.jboss.org/jira/browse/JBSEAM-3408
>             Project: Seam
>          Issue Type: Feature Request
>          Components: Security
>    Affects Versions: 2.1.0.BETA1
>            Reporter: Jacob Orshalick
>            Assignee: Shane Bryzak
>            Priority: Optional
>         Attachments: HashAlgorithm.java
>
>
> As specified in the documentation, the available hash algorithm string values are the strings: md5, sha.  There is also a value of "none" which is not specified in the documentation but avoids hashing the password all-together.  It would be nice to wrap these strings with an enumeration that holds the necessary String values for a bit more type-safety when using the annotation.  This would also help to make the options it a bit more clear from a user perspective.
> The annotation could then be defined as:
> @Target({METHOD,FIELD})
> @Documented
> @Retention(RUNTIME)
> @Inherited
> public @interface UserPassword
> {
>    HashAlgorithm hash() default HashAlgorithm.MD5;
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira