[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-4236) CLONE -captureCurrentView on redirect should capture all request parameters

[Dan Allen (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBSEAM-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12471728#action_12471728 ] 

Dan Allen commented on JBSEAM-4236:
-----------------------------------

Doh! That's right. If you want to preserve the URI fragment, you are on your own (since Seam cannot process information it doesn't receive).

One idea is to store the current URL in a cookie when the user clicks on a link which may require authorization. Then, in a post-authenticate observer, you can read the cookie value and redirect to it. Since this requires JavaScript to store the current URL, and is likely not going to be comfortable for some users, we can't put it in Seam.

> CLONE -captureCurrentView on redirect should capture all request parameters
> ---------------------------------------------------------------------------
>
>                 Key: JBSEAM-4236
>                 URL: https://jira.jboss.org/jira/browse/JBSEAM-4236
>             Project: Seam
>          Issue Type: Bug
>    Affects Versions: 2.1.2.GA
>         Environment: Win XP
>            Reporter: Paul Chan
>            Assignee: Dan Allen
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> I have tested this fix in 2.1.2 and it is still not working.  Here is my test case:
> ../mydomain/test.seam?cmid=10#menu:test_view&tab:test1
> Only cmid=10 is carried over after i login.  Anything after the # sign is not carried over to the new page.  It seems to me that when the page was redirected to the login page the parametes are carried over, but as soon as i enter the login name and password and I was redirected to the original page all the parameters after the # sign are lost.
> ===============================================================
> When the captureCurrentRequest() method was deprecated and replaced by captureCurrentView(), the behavior changed such that page parameters were being saved instead of request parameters. I'm fine with the idea of preserving page parameters based on how they were bound to the model on the way into the page, but I also think that arbitrary request parameters need to be captured. Otherwise, the redirect back to the current view will in many cases be incomplete and thus fail. The logic I propose is to capture the request parameters and then override the values with the values from the page parameters (giving page parameters the precedence).
> However, long term, we should also consider the fact that multi-value parameters are not being preserved. Likely they should be captured as well, but there is a lack of infrastructure to support them.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira