[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-4131) Regression: EL expressions in messages not working anymore

[Riccardo Serafin (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBSEAM-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12472013#action_12472013 ] 

Riccardo Serafin commented on JBSEAM-4131:
------------------------------------------

Hi,

I believe the change have introduced a performance regression. 

If my understanding is correct, the new implementation of the AbstractMap in Messages does not implement the ContainsKey method which, due to the change introduced by JBSEAM-3916, is called by the SeamELResolver. This in turns requires the very expensive entrySet which results in a performance hit, as already fixed by JBSEAM-2192 (which this change has reverted). 

If my analysis is correct, please add again the fix from http://fisheye.jboss.org/browse/Seam/trunk/src/main/org/jboss/seam/international/Messages.java?r=6789.

Best,
Riccardo.

> Regression: EL expressions in messages not working anymore
> ----------------------------------------------------------
>
>                 Key: JBSEAM-4131
>                 URL: https://jira.jboss.org/jira/browse/JBSEAM-4131
>             Project: Seam
>          Issue Type: Bug
>    Affects Versions: 2.1.2.CR1
>            Reporter: Jonas Buechel
>            Assignee: Norman Richards
>             Fix For: 2.1.2.CR2
>
>
> Since I upgraded to 2.1.2.CR1 I'm facing problems with EL expressions within messages files. Which means:
> The value of
> controls_logout_user=#{identity.username} abmelden
> won't be rendered anymore.
> Code:
> <s:link action="#{identity.logout}" value="#{messages.controls_logout_user}" 
> rendered="#{identity.loggedIn}" propagation="none" />
> HTML Result:
> <a id="fwcMenuForm:j_id51" 
> href="http://localhost:80/home?actionMethod=modules%2Fhome.xhtml%3Aidentity.logout"/>
> Expected HTML Result:
> <a id="fwcMenuForm:j_id51" 
> href="http://localhost:80/home?actionMethod=modules%2Fhome.xhtml%3Aidentity.logout">username abmelden</a>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira