[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-4244) fix for JBSEAM-4131 introduced a performance regression

Tue Jun 16 13:30:57 EDT 2009

    [ https://jira.jboss.org/jira/browse/JBSEAM-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12472378#action_12472378 ] 

Riccardo Serafin commented on JBSEAM-4244:
------------------------------------------

Thanks, 

i've tested the patch and it looks like this solves the problem. At least as far my test page was involved. Just to give you the idea, the total time spent in SeamELResolver.resolveInMap method when reloading my page has gone from 0.2ms to 1300ms from 2.1.1 to 2.1.2 and back to 0.2ms with 2.2.0-SNAPSHOT.

I've attached an excel file with the results of my test. One problem that is still there, however, is that the containsKey over the messages does still suffer from the performance problem. So i believe the author of JBSEAM-2192  will still be quite unhappy.

Moreover, I wanted to ask why you had to change the AbstractMap.get method, and why in the current version you interpolate the obtained from the bundle, given that SeamResouceBundle is already interpolating.

Finally, as it seems you are dealing with the SeamELResolver a lot, I was wondering if have you had time to look at this other post of mines related to resolver performance (http://www.seamframework.org/Community/SeamELResolverPerformanceIssues)? 

Thanks a lot in the meantime.

> fix for JBSEAM-4131 introduced a performance regression
> -------------------------------------------------------
>
>                 Key: JBSEAM-4244
>                 URL: https://jira.jboss.org/jira/browse/JBSEAM-4244
>             Project: Seam
>          Issue Type: Bug
>          Components: Core
>            Reporter: Pete Muir
>            Assignee: Norman Richards
>             Fix For: 2.2.0.CR1
>
>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira