[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-4001) Wicket Instrumentation Annotation

[Paul Mooney (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBSEAM-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12458501#action_12458501 ] 

Paul Mooney commented on JBSEAM-4001:
-------------------------------------

The maven plugin doesn't seem to have target/classes (the classesDirectory) in its classpath when it runs. Because of this, if there are any custom TYPE targeted annotations on any of the classes that fit the includes patterns while 'scanAnnotations' is true, the 'JavassistInstrumentor' throws a ClassNotFoundException while making a call to CtClass.getAnnotations(). 

I recommend replacing all calls to 'getAnnotations()' in 'JavassistInstrumentor' with 'getAvailableAnnotations()', which will safely ignore anything that is not in the seam-instrument-wicket plugin's classpath. 

Should this be a new JIRA issue?

> Wicket Instrumentation Annotation
> ---------------------------------
>
>                 Key: JBSEAM-4001
>                 URL: https://jira.jboss.org/jira/browse/JBSEAM-4001
>             Project: Seam
>          Issue Type: Feature Request
>          Components: Wicket
>            Reporter: Paul Mooney
>            Assignee: Clint Popetz
>             Fix For: 2.1.2.CR1
>
>
> Instrument wicket classes which are annotated with a seam annotation (something like @WicketComponent), as well as all of their non-static nested classes (including anonymous). 
> This would be an alternative to the current approach of using filesets or package patterns to determine which classes to pass to the JavassistInstrumentor (either via ant,maven, or javaagent). 
> As well, if possible, this may be an alternative to placing wicket classes in WEB-INF/wicket at runtime. In this case some configuration might be needed to enable/disable runtime instrumentation in order to avoid attempts to re-instrument classes which have already been instrumented at buildtime.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira