[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2209) Fix passivation/activation of entities loaded using an SMPC
Wolfgang Schwendt (JIRA)
jira-events at lists.jboss.org
Sat Mar 28 15:58:22 EDT 2009
[ https://jira.jboss.org/jira/browse/JBSEAM-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12459493#action_12459493 ]
Wolfgang Schwendt commented on JBSEAM-2209:
yes, Darryll, it's a bug. And perhaps this JIRA case should be reopened again.
The question is whether in Manager.switchConversation(String id) the call setLongRunningConversation(true); is really necessary. ConversationEntries exist only for long-running conversations, and Manager.switchConversation() can only succesfully switch to a conversation for which a ConversationEntry exists.
A ConversationEntry also exists for a temporary conversation that has been temporarily promoted to a long-running conversation. For such kind of conversations, Manager.restoreAndLockConversation() sets the removeAfterRedirect flag to false during the attemp to restore the conversation. So if we delete the call setLongRunningConversation(true) in Manager.switchConversation(String id), Manager.switchConversation(String id) would possibly allow us to switch to a temporary conversation that was previously promoted to a long running conversation and then demoted back to a temporary conversation. But would that be a problem? Have to think more thoroughly about this.
> Fix passivation/activation of entities loaded using an SMPC
> Key: JBSEAM-2209
> URL: https://jira.jboss.org/jira/browse/JBSEAM-2209
> Project: Seam
> Issue Type: Bug
> Components: Core
> Reporter: Wolfgang Schwendt
> Assignee: Dan Allen
> Priority: Blocker
> Fix For: 2.1.1.CR1
> Attachments: nestedConversationsBehavior-Screenshots.pdf, nestedConversationsBehavior.zip
> When a nested conversation ends, it is difficult to transfer an ending result back to the parent conversation. The following approach is currently not viable with Seam: We cannot simply access a component from the parent conversation and call a property Setter of this component with the ending result of the nested conversation supplied as argument for this Setter. The reason is that when a component from the parent conversation is called while the nested conversation is still in progress, the ManagedEntityIdentityInterceptor saves wrappers for the called component in the scope of the nested conversation (!) and not the scope of the parent conversation. So once the nested conversation scope gets destroyed at the end of the nested conversation, the saved wrappers for the component from the parent conversation get destroyed as well.
> Suppose that we have a component AA in the conversation context with a field reference named 'bb' to an another component Q. At some point of time this reference is moved by the ManagedEntityIdentityInterceptor to a conversation-scoped context variable with the name "AA.bb". Then we start a nested conversation. While the nested conversation is in progress, we can call a method of component AA and successfully access the field bb because at the time of the method invocation, the ManagedEntityIdentityInterceptor can retrieve the saved wrapper for field bb from the parent conversation context and put the contained reference into the component AA.
> But then we call a method of component AA which changes the field bb. At the end of this method invocation, the ManagedEntityIdentityInterceptor moves the new value of reference field bb to a wrapper saved in the nested (!) conversation context. Afterwards we end the nested conversation and the parent conversation resumes again. When we then call a method of component AA again, the ManagedEntityIdentityInterceptor retrieves the wrapper for field bb from the conversation context. But this wrapper contains the old value for field bb, not the new value. Note that the wrapper with the new value for field bb got destroyed already at the time when the nested conversation context was destroyed.
> Feature request regarding nested conversations
> Tue Sep 18, 2007 00:28 AM
> Nested Conversations (tricky interceptor)
> Mon Oct 22, 2007 11:03 AM
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the seam-issues