[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-4056) "value required" message for missing page param should give name of missing parameter

Norman Richards (JIRA) jira-events at lists.jboss.org
Mon Mar 30 17:23:22 EDT 2009


    [ https://jira.jboss.org/jira/browse/JBSEAM-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12459731#action_12459731 ] 

Norman Richards commented on JBSEAM-4056:
-----------------------------------------

I'm not sure I agree.  With this change, it would never be possible to use a message that didn't have the name appended.   Is the field not passed in as the {0} parameter for the required field message?

> "value required" message for missing page param should give name of missing parameter
> -------------------------------------------------------------------------------------
>
>                 Key: JBSEAM-4056
>                 URL: https://jira.jboss.org/jira/browse/JBSEAM-4056
>             Project: Seam
>          Issue Type: Patch
>          Components: Core
>    Affects Versions: 2.1.1.GA
>         Environment: Kubuntu 8, jboss-seam-2.1.1.GA/
>            Reporter: Ian Darwin
>         Attachments: to.seam
>
>
> When you somehow submit a post with a missing page param, the stack trace only says:
> javax.faces.validator.ValidatorException: value is required
>         at org.jboss.seam.navigation.Param.addRequiredMessage(Param.java:272)
>         at org.jboss.seam.navigation.Param.getStringValueFromRequest(Param.java:175)
>         ... 
> The attached patch changes the message to
> javax.faces.validator.ValidatorException: value is required pKey
> making it much easier to diagnose the problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        



More information about the seam-issues mailing list