[jbossseam-issues] [JBoss JIRA] Resolved: (JBSEAM-3032) count query used by Query is not compliant JPQL

[Dan Allen (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBSEAM-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Allen resolved JBSEAM-3032.
-------------------------------

    Resolution: Done


I introduced a lightweight feature checking framework on PersistenceProvider (can be expanded/refactored in the future)

PersistenceProvider has a public enum named Feature
That enum contains features that can be claimed by a provider
By default no features are supported by the base persistence provider (for now)
The HibernatePersistenceProvider supports the Feature WILDCARD_AS_COUNT_QUERY_SUBJECT
The features are added in the @PostConstruct init() method
Clients check for a feature using PersistenceProvider#supportsFeature(Feature)
EntityQuery checks for this feature when determining whether to use a wildcard or the entity name/alias for the count query subject

> count query used by Query is not compliant JPQL
> -----------------------------------------------
>
>                 Key: JBSEAM-3032
>                 URL: https://jira.jboss.org/jira/browse/JBSEAM-3032
>             Project: Seam
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 2.0.2.GA, 2.1.0.A1
>            Reporter: Dan Allen
>            Assignee: Dan Allen
>             Fix For: 2.2.0.CR1
>
>         Attachments: JBSEAM-3032-branch20-v1.txt, JBSEAM-3032-trunk-v1.txt, JBSEAM-3032-trunk-v2.txt
>
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> The count query used by getCountEjbQl() in Query is not compliant JPQL. It should be:
> select count(Entity) from Entity entity
> instead of
> select count(*) from Entity entity
> Where "entity" is the class name of the entity (for instance, Person). You can test this by using TopLink or OpenJPA.
> All we need to do is replace the * with the name of the Entity. (We don't even need to fish for the alias used in the query).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira