[seam-issues] [JBoss JIRA] Commented: (SEAMINTL-1) TimeZone handling based on Seam 2

Fri Apr 9 13:46:43 EDT 2010

    [ https://jira.jboss.org/jira/browse/SEAMINTL-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12524952#action_12524952 ] 

Ken Finnigan commented on SEAMINTL-1:
-------------------------------------

In terms of formatting, that's probably true as I have not had a chance to run the code through the formatter once Dan created it for Seam 3.  Will do that shortly.

Fair point on the @TimeZones qualifier, probably being a little over zealous in my qualifiers in an attempt to prevent conflicts.

On the init method I thought from the Weld documentation that @Inject was the right thing to do, as well as from other module code I have seen.  What is the significant difference or benefit in the two approaches?

With @DefaultTimeZone that probably is too verbose, and thinking further I could probably remove the need for a qualifier on the application scoped timezone and just have one on the user scoped timezone.

With TimeZoneWrapper, kind of just took that from Seam 2 without really understanding the benefit or purpose of it, apart from some nicer formatting methods.  Happy to be directed to a better way to achieve the goal.

By test in a sub package do you mean not in src/test/java? Or just that the package of the test would not be the same as the class that it is testing?

I'd created TimeZoneSelectedEvent to capture changes in the User timezone.  I'm confused by your suggestion.  Are you suggesting raising an event through a qualifier, how would that work?  Still learning about CDI so interested in learning the best practices, etc 

> TimeZone handling based on Seam 2
> ---------------------------------
>
>                 Key: SEAMINTL-1
>                 URL: https://jira.jboss.org/jira/browse/SEAMINTL-1
>             Project: Seam i18n
>          Issue Type: Task
>          Components: Time zones
>            Reporter: Ken Finnigan
>            Assignee: Ken Finnigan
>             Fix For: 3.0.0.Alpha1
>
>         Attachments: timezones.txt
>
>
> Develop similar functionality to that present in the existing Seam 2 source for handling timezones

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira