[seam-issues] [JBoss JIRA] Closed: (JBSEAM-4675) LogImpl.interpolate() is broken

[Marek Novotny (JIRA)]

     [ https://jira.jboss.org/browse/JBSEAM-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marek Novotny closed JBSEAM-4675.
---------------------------------

         Assignee: Marek Novotny
    Fix Version/s: 2.2.1.CR2
       Resolution: Duplicate Issue


this issue duplicated issue JBSEAM-4606

> LogImpl.interpolate() is broken
> -------------------------------
>
>                 Key: JBSEAM-4675
>                 URL: https://jira.jboss.org/browse/JBSEAM-4675
>             Project: Seam
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.2.1.CR1
>            Reporter: Stephan Bublava
>            Assignee: Marek Novotny
>             Fix For: 2.2.1.CR2
>
>
> This is the implementation of LogImpl.interpolate():
>    private Object interpolate(Object object, Object... params)
>    {
>       if (object instanceof String)
>       {
>          try {
>             return Interpolator.instance().interpolate( (String) object, params );
>          } catch (Exception e) {
>             log.error("exception interpolating string: " + object, e);
>          } finally {
>             return object;
>          }
>          
>       }
>       else
>       {
>          return object;
>       }
>    }
> The return statement in the finally block is bogus, because it trumps the other one. In other words the method always returns "object" and discards the result of the interpolation.
> This is a regression from 2.2.0.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira