[seam-issues] [JBoss JIRA] Commented: (JBSEAM-4284) Wrong pageflow name in case of nested conversation

[Marek Novotny (JIRA)]

    [ https://jira.jboss.org/browse/JBSEAM-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556465#action_12556465 ] 

Marek Novotny commented on JBSEAM-4284:
---------------------------------------

I looked at the sources and patch and I am not sure that this issue is only in fixing position of pageflow name substring. Documentation says that type should be type="nested", but propagation type in Enum is org.jboss.seam.core.PropagationType.NEST. Anyway you can set the type attribute to whatever you want, it is not validated if it should be nest or nested.

Have you tried to use type="nest" instead of type="nested"? 

> Wrong pageflow name in case of nested conversation
> --------------------------------------------------
>
>                 Key: JBSEAM-4284
>                 URL: https://jira.jboss.org/browse/JBSEAM-4284
>             Project: Seam
>          Issue Type: Bug
>    Affects Versions: 2.1.2.GA
>            Reporter: Vesa Hiltunen
>         Attachments: JBSEAM-4284, JBSEAM-4284.stacktrace.txt
>
>
> I tried to start nested conversation with new pageflow as follows: 
>    <s:link value="DoIt" action="/pages/myPage.xhtml">
>       <s:conversationPropagation type="nested" pageflow="myPageflowName" />
>    </s:link>
> Seam did not find pageflow because it is looking for pageflow named as: d.myPageflowName
> Request parameter was: conversationPropagation=nested.myPageflowName
> It looks like method getPropagationFromRequestParameter(Map parameters) in org.jboss.seam.core.ConversationPropagation contains a bug. Method assumes that string "nested." was "nest."
> Current code: 
>    else if (value.startsWith("nest"))
>    {
>       propagationType = PropagationType.NEST;
>       if ( value.length()>5 )
>       {
>          pageflow = value.substring(5);
>       }         
>    }
> One way to fix the code: 
>    else if (value.startsWith("nest"))
>    {
>       propagationType = PropagationType.NEST;
>       if ( value.length()>7 )
>       {
>          pageflow = value.substring(7);
>       }         
>    }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira