[seam-issues] [JBoss JIRA] (SEAMSECURITY-136) JpaIdentityStoreConfiguration does not correctly support subclasses

[John Schneider (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/SEAMSECURITY-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653285#comment-12653285 ] 

John Schneider commented on SEAMSECURITY-136:
---------------------------------------------

The attached patch:
1. Introduces recursive method to climb entity hierarchy to determine which class has the @IdentityEntity annotation
2. Introduces logging to note which JPA Identity Store Identity Entity classes were determined for each respective entity

I've tested it and found that it fixes my problems. Please consider it for inclusion in the next release.
                
> JpaIdentityStoreConfiguration does not correctly support subclasses
> -------------------------------------------------------------------
>
>                 Key: SEAMSECURITY-136
>                 URL: https://issues.jboss.org/browse/SEAMSECURITY-136
>             Project: Seam Security
>          Issue Type: Bug
>    Affects Versions: 3.1.0.CR1
>         Environment: Glassfish 3.1.1
>            Reporter: John Schneider
>         Attachments: JpaIdentityStoreConfiguration.diff.txt
>
>
> If an entity annotated with @IdentityEntity has subclasses, the value of the identityClass, credentialClass, relationshipClass, attributeClass and roleTypeClass variables of JpaIdentityStoreConfiguration are overwritten by their respective subclasses, as they inherit the annotation (at least in Glassfish Weld implementation).  This causes errors in methods such as JpaIdentityStore.configureAttributes, as it is looking only at the subclass for an association to the identityClass, etc. (e.g. error: "Error initializing JpaIdentityStore - no attribute identity property found").
> Within JpaIdentityStoreConfiguration.processAnnotatedType, is it possible to identify which class was explicitly annotated?  If not, then perhaps the best approach is to identify the parent class that is annotated and disregard any subclasses.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira