[seam-issues] [JBoss JIRA] Commented: (SEAMFACES-46) @End should probably not throw exceptions if a conversation could not be ended because it does not exist

[Sebastian Sachtleben (JIRA)]

    [ https://issues.jboss.org/browse/SEAMFACES-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627665#comment-12627665 ] 

Sebastian Sachtleben commented on SEAMFACES-46:
-----------------------------------------------

Added check for conversation.isTransient() on endConversation method. Properly tested, no more exception occur just debug log message "No conversation found after method".

The current behavior of @Begin is, that every invoke of that method creates a new conversation. The first invoke creates conversation id 1. The next invoke beginConversation of ConversationBoundaryInterceptor still says conversation id is null and transient. Its not possible to add a check to keep the same conversation like @Begin(join=true). The @End invoke is fine. Conversation id is set. But why is the conversation id null on beginConversation even if its invoked before?

> @End should probably not throw exceptions if a conversation could not be ended because it does not exist
> --------------------------------------------------------------------------------------------------------
>
>                 Key: SEAMFACES-46
>                 URL: https://issues.jboss.org/browse/SEAMFACES-46
>             Project: Seam Faces
>          Issue Type: Feature Request
>          Components: Conversations
>    Affects Versions: 3.0.0.Alpha3
>            Reporter: Lincoln Baxter III
>            Assignee: Sebastian Sachtleben
>             Fix For: 3.1.0.Tracking
>
>
> The @End annotation calls conversation.end() without first checking conversation.isTransient(). This results in exceptions when invoking the method on a transient conversation.
> This should either be a configuration option of the annotation, or should not occur:
> @End(ConversationPropagation.REQUIRED)
> @End(ConversationPropagation.OPTIONAL)
> Etc... something like that().

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira