[seam-issues] [JBoss JIRA] (SEAMFACES-233) WebXmlProjectStageDetector should use Solder's WebResourceLocator

[Christian Kaltepoth (Updated) (JIRA)]

     [ https://issues.jboss.org/browse/SEAMFACES-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Kaltepoth updated SEAMFACES-233:
------------------------------------------

              Status: Pull Request Sent  (was: Open)
    Git Pull Request: https://github.com/seam/faces/pull/67


I just opened a pull request for this.

The first commit of this pull request contains the actual migration to the WebResourceLocator API of Solder.

The second commit contains a major reorganization of the integration tests for the ProjectStageExtension. I added a dedicated test covering the lookup of the web.xml. All tests for the ProjectStageExtension are now server-based which means that they will be executed in the JBossAS and Glassfish profiles.

                
> WebXmlProjectStageDetector should use Solder's WebResourceLocator
> -----------------------------------------------------------------
>
>                 Key: SEAMFACES-233
>                 URL: https://issues.jboss.org/browse/SEAMFACES-233
>             Project: Seam Faces
>          Issue Type: Enhancement
>    Affects Versions: 3.1.0.Final
>            Reporter: Christian Kaltepoth
>            Priority: Minor
>
> WebXmlProjectStageDetector use some code that is able to find the location of web.xml without using the ServletContext. In the meantime this code has been moved to Solder. Therefore the old Seam Faces implementation should be removed and the WebXmlProjectStageDetector should use the new WebResourceLocator provided by Solder.
> I just started to work on this. I'll open a pull request soon.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira