[seam-issues] [JBoss JIRA] (JBSEAM-4889) Improvements to maven-ear-plugin configuration of seam booking 2.3

[Marek Novotny (JIRA)]

    [ https://issues.jboss.org/browse/JBSEAM-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661467#comment-12661467 ] 

Marek Novotny commented on JBSEAM-4889:
---------------------------------------

that is true, all examples are affected. thanks for feedback, we need to update this as migration to maven is now almost year old. 
                
> Improvements to maven-ear-plugin configuration of seam booking 2.3
> ------------------------------------------------------------------
>
>                 Key: JBSEAM-4889
>                 URL: https://issues.jboss.org/browse/JBSEAM-4889
>             Project: Seam 2
>          Issue Type: Bug
>    Affects Versions: 2.3.0.ALPHA
>            Reporter: Fred Bricon
>             Fix For: 2.3.0.Final
>
>
> While testing seam booking with m2e-wtp/JBT, I noticed a few things you might want to fix wrt the [maven-ear-plugin configuration|http://anonsvn.jboss.org/repos/seam/branches/community/Seam_2_3/examples/booking/booking-ear/pom.xml] :
> - maven-ear-plugin <version>2.3.2</version> is kinda obsolete, you can bump it to 2.6. Moreover, version is managed in a parent pom so could be removed altogether in the ear project.
> - EAR <version> is not set in <configuration>, so by default an application.xml 1.3 will be generated (and Facet 1.3 will be installed in WTP). You should set <version>5</version>
> - <earSourceExcludes>**/application.xml, **/jboss-app.xml</earSourceExcludes> was added when m2e-wtp was creating these files (like 2 years ago). I'd remove that now.
> - <generateApplicationXml>true</generateApplicationXml> is redundant (it's the default value) and can be removed

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira