[seam-issues] [JBoss JIRA] (JBSEAM-4654) s:selectItems noSelectionLabel does not generate option value

Tiago Peruzzo (JIRA) jira-events at lists.jboss.org
Fri Sep 14 16:17:33 EDT 2012

    [ https://issues.jboss.org/browse/JBSEAM-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718800#comment-12718800 ] 

Tiago Peruzzo commented on JBSEAM-4654:

Marek, this error also occurs in version 2.3.0.CR1 maybe not for the same reasons, try adding a convert select the problem will happen.

<h:selectOneMenu value="#{myComponent.value}">
	<f:converter converterId="myConverter" />
	<s:selectItems value="#{myComponent.itens}" var="item" label="#{item.label}" noSelectionLabel=""/>

I noticed that this occurs because changes were made in classes and com.sun.faces.renderkit.html_basic.MenuRenderer and com.sun.faces.renderkit.RenderKitUtils starting the JSF2 ... 's kinda hard to explain why more and debugging methods renderSelect RenderOptions can help.

I made a patch putting the logic of creation of the ConverterChain  at the beginning in encodeEnd method.
> s:selectItems noSelectionLabel does not generate option value
> -------------------------------------------------------------
>                 Key: JBSEAM-4654
>                 URL: https://issues.jboss.org/browse/JBSEAM-4654
>             Project: Seam 2
>          Issue Type: Bug
>          Components: JSF Controls
>    Affects Versions: 2.2.1.CR1
>         Environment: JBoss 6 M3
>            Reporter: Andrew Wheeler
>            Assignee: Marek Novotny
>              Labels: jsf
>             Fix For: 2.3.0.CR1
>   Original Estimate: 2 hours
>  Remaining Estimate: 2 hours
> When a selectOneMenu has no items other than the no selection option it does not render the option value as org.jboss.seam.ui.NoSelectionConverter.noSelectionValue. In this case the there are no values in person.images.
> <h:selectOneMenu id="portrait" value="#{person.portrait}">
>     <s:selectItems value="#{person.images}" var="i" label="#{i.annotation}" hideNoSelectionLabel="false" noSelectionLabel="Select a portrait..."/>
>     <s:convertEntity/>			
> </h:selectOneMenu>
> This renders:
> <select id="person:portraitDecoration:portrait" name="person:portraitDecoration:portrait" size="1">	<option selected="selected">Select a portrait...</option>
> </select>
> The result is that any form submit causes a java.lang.NumberFormatException with message: "For input string: "Select a portrait..."" 
> I have debugged a little and I can see that the converter is not firing when rendering the page. It does however fire for other selectOneMenu items on the page that have one or more items.
> A similar and perhaps related issue is referenced in the JBoss Forum.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

More information about the seam-issues mailing list