[seam-issues] [JBoss JIRA] (JBSEAM-5085) Pages rewrite doesn't rewrite s:link params

[Marek Novotny (JIRA)]

    [ https://issues.jboss.org/browse/JBSEAM-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775033#comment-12775033 ] 

Marek Novotny edited comment on JBSEAM-5085 at 5/17/13 8:50 AM:
----------------------------------------------------------------

I figured out how to change the incorrect behavior of {{org.jboss.seam.ui.util.ViewUrlBuilder}}. The existence of {{viewHandler.getBookmarkableUrl}} was premature to call in {{ViewUrlBuilder}} initialization, because we need added parameters in URL. So after discussion with Marek Schmidt I prepared the change. However that change broke the calling of page actions due double url encoding - experienced in {{org.jboss.seam.test.integration.faces.conversations.ConversationPropagationsTest.testSButtonActionPropagationNone()}}. So I changed default url encoding to false in {{org.jboss.seam.ui.util.ViewUrlBuilder.ViewUrlBuilder(String, String)}}.

The test case for Page rewrite is added as {{org.jboss.seam.test.integration.faces.ViewUrlBuilderTest}}.
                
      was (Author: manaRH):
    I figured out how to change the incorrect behavior of org.jboss.seam.ui.util.ViewUrlBuilder. The existence of viewHandler.getBookmarkableUrl was premature to call in ViewUrlBuilder initialization, because we need added parameters in URL. So after discussion with Marek Schmidt I prepared the change. However that change broke the calling of page actions due double url encoding - experienced in org.jboss.seam.test.integration.faces.conversations.ConversationPropagationsTest.testSButtonActionPropagationNone(). So I changed default url encoding to false in org.jboss.seam.ui.util.ViewUrlBuilder.ViewUrlBuilder(String, String).

The test case for Page rewrite is added as org.jboss.seam.test.integration.faces.ViewUrlBuilderTest.
                  
> Pages rewrite doesn't rewrite s:link params
> -------------------------------------------
>
>                 Key: JBSEAM-5085
>                 URL: https://issues.jboss.org/browse/JBSEAM-5085
>             Project: Seam 2
>          Issue Type: Bug
>          Components: JSF Controls
>            Reporter: Marek Novotny
>            Assignee: Marek Novotny
>             Fix For: 2.3.1.CR1
>
>
> Having this in the pages.xml:
> <page view-id="/entry.xhtml"> 
>         <rewrite pattern="/entry/{blogEntryId}" />
>         <rewrite pattern="/entry" />
>         
>         <param name="blogEntryId" 
>                value="#{blogEntry.id}"/>
>         
>         <action execute="#{entryAction.loadBlogEntry(blogEntry.id)}"/>
>     </page>
> and a link to entry in a page:
> <s:link id="link" view="/entry.xhtml" propagation="none" value="#{blogEntry.title}">
>    <f:param name="blogEntryId" value="#{blogEntry.id}"/>
> </s:link>
> this should render as a link to "/entry/foo", but it renders as "/entry?blogEntryId=roadmap11"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira