[security-dev] Refactoring of picketlink-integration-tests

[Pedro Igor Silva]

+1000.

I think you're already covering many of the issues: ant, xslt, better arquillian usage, etc. And most important a single workspace where both community and productization can use, if possible.

Just one thought. Our integration suite allows to run tests for a particular feature set (ws-trust, saml, trust, etc). I think we should keep that.

Regards.
Pedro Igor

----- Original Message -----
From: "Ondra Lukas" <olukas at redhat.com>
To: security-dev at lists.jboss.org
Sent: Thursday, May 23, 2013 4:10:07 AM
Subject: [security-dev] Refactoring of picketlink-integration-tests

Hi,
we would like to do some refactoring of PicketLink integration testsuite for easier QE testing with new versions of EAP. We have some ideas how to improve it and I want to ask you what do you think about that. Here is the list, we would like to:

1) change of configuration which running specified tests for specified container. It is currently set by @TargetContainers annotation. We prefer to using better usage of maven profiles and for instance Java subpackages according to profiles. Every subpackage will contain tests which will run only in that profile (for example org.picketlink.test.trust.tests.eap6 will contain tests for EAP6 profile). Tests which run in every profile will stay in current packages. Tests which run in more profiles (but not in all of them) will be added by include/exclude parameters of maven-failsafe-plugin.

Why?
It will be easier to configurate it for QE testing. We need some easy way how to see each test of some profile. Currently we have all tests together and it's quite uncomfortable. It will be simpler to add a new container too.

2) avoid use of Ant and try to rewrite it to maven (using Maven Resource Plugin etc.).

Why?
We want to have ability of setting properties from command line (which is not handled correctly by maven-antrun-plugin). Also we want to have only one type of configuration files.

3) create Arquillian's ServerSetupTasks for setting containters (setting security domains for testing etc.).

Why?
We want to avoid XSLT because it is sometimes out of work in diffrent type of JDKs.

4) remove "dist" folders from every container (/integration-tests/CONTAINER/dist) and remove distributions from dist. We will use only one dist folder which will be located in integration-tests folder. 

Why?
If anybody is cloning picketlink-integration-tests from git, he have to clone distributions, but it take a lot of unnecessary time. We think that better way is have one empty folder for all distributions. User can input nedded distributions.

What do you think about that? Does anybody have any idea about improvement of picketlink-integration-tests testsuite?

Thanks,
Ondrej Lukas
_______________________________________________
security-dev mailing list
security-dev at lists.jboss.org
https://lists.jboss.org/mailman/listinfo/security-dev