[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-64) Change ZipExporter to return a ZipInputStream

Andrew Lee Rubinger (JIRA) jira-events at lists.jboss.org
Wed Oct 21 14:45:06 EDT 2009


    [ https://jira.jboss.org/jira/browse/SHRINKWRAP-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12490791#action_12490791 ] 

Andrew Lee Rubinger commented on SHRINKWRAP-64:
-----------------------------------------------

We originally tried this approach.  The problem is that wrapping in ZipInputStream means we cannot simply treat the returned object as any ol' InputStream of bytes.  When writing to disk, then reopening in a roundtrip, this occurs:

java.util.zip.ZipException: error in opening zip file
	at java.util.zip.ZipFile.open(Native Method)
	at java.util.zip.ZipFile.<init>(ZipFile.java:114)
	at java.util.zip.ZipFile.<init>(ZipFile.java:131)
	at org.jboss.shrinkwrap.impl.base.export.ZipExporterTestCase.getExportedZipFile(ZipExporterTestCase.java:215)
	at org.jboss.shrinkwrap.impl.base.export.ZipExporterTestCase.testExportZip(ZipExporterTestCase.java:81)

...wrapping should keep all other activity transparent and simply add new support.  ZIS does not.

> Change ZipExporter to return a ZipInputStream
> ---------------------------------------------
>
>                 Key: SHRINKWRAP-64
>                 URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-64
>             Project: ShrinkWrap
>          Issue Type: Feature Request
>          Components: api
>    Affects Versions: 1.0.0-alpha-1
>            Reporter: Jesper Pedersen
>
> Change the ZipExporter to return a ZipInputStream instead of an InputStream.
> Alternative: Rename the class to InputStreamExporter

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the shrinkwrap-issues mailing list