[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-240) addServiceProvider should add class to archive
Dan Allen (JIRA)
jira-events at lists.jboss.org
Mon Nov 8 20:12:01 EST 2010
[ https://jira.jboss.org/browse/SHRINKWRAP-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562026#action_12562026 ]
Dan Allen commented on SHRINKWRAP-240:
--------------------------------------
The issue here is that perhaps the service provider aspect shouldn't be linked directly to manifest container, as it doesn't always apply. The service provider should only be a method on JavaArchive and WebArchive. If you are adding a service, you should be able to also add a class. Those two are linked.
> addServiceProvider should add class to archive
> ----------------------------------------------
>
> Key: SHRINKWRAP-240
> URL: https://jira.jboss.org/browse/SHRINKWRAP-240
> Project: ShrinkWrap
> Issue Type: Feature Request
> Components: api
> Affects Versions: 1.0.0-alpha-11
> Reporter: Dan Allen
> Priority: Minor
>
> My intuition tells me that addServiceProvider should add the service provider classes I specify to the archive. To my surprise, it does not. I can't see any scenario in which you specify a service provider for a class that isn't in the archive. For the edge case, you could always extract it manually after the call to addServiceProvider.
> Currently:
> addClass(MyServiceImpl.class).addServiceProvider(Service.class, MyServiceImpl.class)
> Proposed:
> addServiceProvider(Service.class, MyServiceImpl.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the shrinkwrap-issues
mailing list