[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-244) When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL gets used instead

[Davide D'Alto (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKWRAP-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595735#comment-12595735 ] 

Davide D'Alto commented on SHRINKWRAP-244:
------------------------------------------

I agree, the inner class is not relevant to this issue.
I will fix the thing that you pointed out in the comment on github and then I will leave at the Shrinkwrap guys the last word :)

Cheers

> When calling JavaArchiveImpl.addClass(String, ClassLoader) the TCCL gets used instead
> -------------------------------------------------------------------------------------
>
>                 Key: SHRINKWRAP-244
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-244
>             Project: ShrinkWrap
>          Issue Type: Bug
>          Components: impl-base
>    Affects Versions: 1.0.0-alpha-12
>            Reporter: David Bosschaert
>            Assignee: Davide D'Alto
>
> When I call JavaArchiveImpl.addClass(String fqcn, ClassLoader cl) the cl gets used to load fqcn, but then further down the line, I find myself in ContainerBase.addPackages(), which is called indirectly from the previous addClass method. The addPackages still uses the TCCL while it should really use the cl passed in to the addClass method.
> This also applies to JavaArchiveImpl.addClass(Class cls) where the classloader to be used could be inferred from the cls argument, but instead the TCCL gets used...

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira