[shrinkwrap-issues] [JBoss JIRA] (SHRINKWRAP-372) create a way to LibraryContainer#addAsLibrary by a given marker file

[Andrew Rubinger (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKWRAP-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651790#comment-12651790 ] 

Andrew Rubinger commented on SHRINKWRAP-372:
--------------------------------------------

I think instead of changing the existing API for LibraryContainer, we should keep using the existing "addAsLibraries" constructs but provide a nice way to get at the desired inputs.

In this case, that'd amount to a new resolver extension to resolve archives from resources found in a given ClassLoader.  For instance (ignore naming/API for now):

  ClassLoaderResolver.resolveArchivesFromResource(ClassLoader,"META-INF/beans.xml") >> returns Set<Archive> or similar

That result can then easily be passed into the existing APIs.
                
> create a way to LibraryContainer#addAsLibrary by a given marker file
> --------------------------------------------------------------------
>
>                 Key: SHRINKWRAP-372
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-372
>             Project: ShrinkWrap
>          Issue Type: Enhancement
>            Reporter: Mark Struberg
>
> When working with CDI Extensions we need to 'package' a whole JAR (or it's whole content) into a JavaArchive which can be used for addAsLibrary based on the marker file "/META-INF/beans.xml".
> This is needed as we cannot simply addAsPackage because the extension jar files would each overwrite other beans.xml files.
> Something like
> LibraryContainer#addContainingLibraries(String markerResource);
> LibraryContainer#addContainingLibraries(String markerResource, String packageNameInclude, String packageNameExclude);
> Example:
> ShrinkWrap.create(WebArchive.class, "test.jar").addContainingLibraries("/META-INF/beans.xml");
> would package all JARs which have a resource "/META-INF/beans.xml", pack them into JavaArchives and add those to the WebArchive.
> With packageNameInclude and packageNameExclude we could add rules about which jars to add and exclude. 
> But I'm sure there is already an established pattern for such a thing in ShrinkWrap.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira