[shrinkwrap-issues] [JBoss JIRA] Resolved: (SHRINKWRAP-240) addServiceProvider should add class to archive

[Andrew Rubinger (JIRA)]

     [ https://issues.jboss.org/browse/SHRINKWRAP-240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Rubinger resolved SHRINKWRAP-240.
----------------------------------------

         Assignee: Davide D'Alto
    Fix Version/s: 1.0.0-beta-3
       Resolution: Done


Upstream: https://github.com/shrinkwrap/shrinkwrap/commit/2fe40c00d8afa6f7bf67ea51cbfb8937656fc393

> addServiceProvider should add class to archive
> ----------------------------------------------
>
>                 Key: SHRINKWRAP-240
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-240
>             Project: ShrinkWrap
>          Issue Type: Feature Request
>          Components: api
>    Affects Versions: 1.0.0-alpha-11
>            Reporter: Dan Allen
>            Assignee: Davide D'Alto
>            Priority: Minor
>             Fix For: 1.0.0-beta-3
>
>
> My intuition tells me that addServiceProvider should add the service provider classes I specify to the archive. To my surprise, it does not. I can't see any scenario in which you specify a service provider for a class that isn't in the archive. For the edge case, you could always extract it manually after the call to addServiceProvider.
> Currently:
> addClass(MyServiceImpl.class).addServiceProvider(Service.class, MyServiceImpl.class)
> Proposed:
> addServiceProvider(Service.class, MyServiceImpl.class)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira