[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKDESC-41) PersistenceUnitDefImpl does not remove non-jta-data-source when configuring jta-data-source (and visa versa)
Lincoln Baxter III (JIRA)
jira-events at lists.jboss.org
Wed Mar 16 22:56:46 EDT 2011
[ https://issues.jboss.org/browse/SHRINKDESC-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588501#comment-12588501 ]
Lincoln Baxter III commented on SHRINKDESC-41:
----------------------------------------------
Fixed methods (depends on SHRINKDESC-39)
@Override
public PersistenceUnitDef nonJtaDataSource(String jndiName)
{
if (jndiName == null)
{
persistenceUnit.remove("non-jta-data-source");
}
else
{
persistenceUnit.removeSingle("jta-data-source");
persistenceUnit.getOrCreate("non-jta-data-source").text(jndiName);
}
return this;
}
@Override
public PersistenceUnitDef jtaDataSource(String jndiName)
{
if (jndiName == null)
{
persistenceUnit.remove("jta-data-source");
}
else
{
persistenceUnit.removeSingle("non-jta-data-source");
persistenceUnit.getOrCreate("jta-data-source").text(jndiName);
}
return this;
}
> PersistenceUnitDefImpl does not remove non-jta-data-source when configuring jta-data-source (and visa versa)
> ------------------------------------------------------------------------------------------------------------
>
> Key: SHRINKDESC-41
> URL: https://issues.jboss.org/browse/SHRINKDESC-41
> Project: ShrinkWrap Descriptors
> Issue Type: Bug
> Components: api
> Affects Versions: 0.1.3
> Reporter: Lincoln Baxter III
> Assignee: Lincoln Baxter III
>
> Setting the value to empty is as good as it gets, but it's not good enough because this doesn't deploy.
> unit.nonJtaDataSource("jndi:blah").jtaDataSource("jndi:blah")
> Results in:
> <jta-data-source>jndi:blah</jta-data-source>
> <non-jta-data-source/>
> But should be simply:
> <jta-data-source>jndi:blah</jta-data-source>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the shrinkwrap-issues
mailing list