[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-264) DescriptorAsset should be a NamedAsset

[Ivan Pazmino (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKWRAP-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592054#comment-12592054 ] 

Ivan Pazmino commented on SHRINKWRAP-264:
-----------------------------------------

Hello Andrew,

The changes were made and commited into my fork github.com/iapazmino/shrinkwrap, and the following files were affected:

modified:   extension-descriptors/pom.xml
The pom was referencing to the 0.1.2 version of descriptors, but compilation failed because the method getDescriptorName was not available. This was fixed changing to the current version 0.1.5-SNAPSHOT

modified:   extension-descriptors/src/main/java/org/jboss/shrinkwrap/api/descriptors/DescriptorAsset.java
The method public String getName() was implemented delegating to the descriptor instance

modified:   extension-descriptors/src/test/java/org/jboss/shrinkwrap/api/descriptors/DescriptorAssetTestCase.java
Two test cases were added to ensure name is not changed. The first one makes an instance of descriptor providing a name; the second uses the default name.

> DescriptorAsset should be a NamedAsset
> --------------------------------------
>
>                 Key: SHRINKWRAP-264
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-264
>             Project: ShrinkWrap
>          Issue Type: Feature Request
>          Components: ext-descriptors
>            Reporter: Aslak Knutsen
>
> Descriptors have a name, Descriptor.getDescriptorName, the DescriptorAsset should be a NamedAsset and use this name as default.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira