[shrinkwrap-issues] [JBoss JIRA] (SHRINKWRAP-261) Shorthand for including maven artifacts

[Andrew Rubinger (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKWRAP-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634259#comment-12634259 ] 

Andrew Rubinger commented on SHRINKWRAP-261:
--------------------------------------------

{code}(12:46:16 PM) kpiwko: as for 4/, I saw that Samuel actually did a copy of MavenBuilderImpl in his shortcut api...it means that internals are not flexible enough
(12:46:46 PM) ALR: Yeah, there's a pending pull request from samaxes on the old Resolver location
(12:47:20 PM) kpiwko: so all updates should leverage MavenResolverInteral so developer wanting to wrap it different way can access the internals
(12:48:20 PM) kpiwko: the same point for MavenImporter...the problem is that we allow to goOffiline() on two of three impls user can access
(12:48:28 PM) kpiwko: this should be consolidated somehow
(12:48:37 PM) samaxes: it was done that way at the time because there were some diferences between the shortcut api and the mavenbuilderimpl
(12:48:42 PM) ALR: What's the overall task we wanna solve here?
(12:48:48 PM) kpiwko: we should have a basic set of operations supported everywhere
(12:48:49 PM) ALR: Just the shortcut API
(12:48:50 PM) ALR: ?
(12:48:54 PM) kpiwko: ALR: jes
(12:48:56 PM) kpiwko: yes
(12:48:58 PM) samaxes: but i'm not up to date with karel code right now
(12:49:09 PM) ALR: OK.  How do we want to resolve this?
(12:49:23 PM) ALR: I'll bet the first step is to rebase samaxes's work on the new resolver location
(12:49:38 PM) jose_freitas: where's the samaxes work ?
(12:50:03 PM) jose_freitas: samaxes's*
(12:50:10 PM) kpiwko: ALR: iirc I already rebased it after same effort with samaxes
(12:50:22 PM) kpiwko: ALR: I should rebase it again on current state
(12:50:46 PM) ALR: jose_freitas has a good question; I thought the latest there was in samaxes fork.
(12:51:10 PM) kpiwko: ALR: however, I didn't merge because I was concerned about c&p stuff samaxes had to do
(12:51:15 PM) samaxes: jose: right now i just have a pull request pending https://github.com/shrinkwrap/resolver/pull/6
(12:51:22 PM) ALR: If not we can rebase against upstream/master and make an upstream/SHRINKWRAP-261 branch
(12:51:23 PM) jbossbot: jira [SHRINKWRAP-261] Shorthand for including maven artifacts [Pull Request Sent (Unresolved) Feature Request, Minor, Samuel Santos] https://issues.jboss.org/browse/SHRINKWRAP-261
(12:51:32 PM) ALR: Then we'll all sync on upstream/SW-261
(12:51:36 PM) samaxes: ynot ready to be merged tight now
(12:51:42 PM) ALR: And keep it rebased atop master
(12:51:42 PM) samaxes: yep, not ready to be merged tight now
(12:51:58 PM) ALR: samaxes: OK, cool.  Would you like to put some work into getting that back into place
(12:51:58 PM) ALR: ?
(12:52:13 PM) ALR: And then when it's ready I can make an upstream branch for it, so it doesn't fall out of favor again?
(12:52:45 PM) samaxes: yep, just need to sync with karel about the recent changes
(12:52:47 PM) kpiwko: or we can release it as a part of 1.1.0 for users who want to use it and fix internals after?
(12:53:32 PM) samaxes: it currently does not compile with 1.1.0-alpha-1-SNAPSHOT
(12:53:42 PM) samaxes: still uses ArtifactAsKey
(12:53:51 PM) jose_freitas: hm
(12:54:07 PM) Jaikiran left the room (quit: Remote host closed the connection).
(12:55:25 PM) kpiwko: samaxes: isn't it possible to simple take MavenBuilderImpl field and let you're methods properly chain required bits?
(12:55:34 PM) kpiwko: sorry,
(12:55:42 PM) kpiwko: MavenBuilderImpl as delegate
(12:56:16 PM) samaxes: there were some differences between them
(12:56:32 PM) samaxes: like not taking transitive dependencies by default
(12:57:03 PM) ALR: Let's stay high-level guys :)
(12:57:08 PM) jose_freitas: hehe
(12:57:09 PM) ALR: The goal is to organize action items.
(12:57:21 PM) ALR: So I can open a new issue, or we can make some notes on SW-261 
(12:57:41 PM) kpiwko: we have some notes on pull request already
(12:57:54 PM) kpiwko: but it makes sense to comment on SW-261 as well
(12:58:00 PM) samaxes: agree
(12:58:01 PM) kpiwko: no need to make a new issue mpov{code}
                
> Shorthand for including maven artifacts
> ---------------------------------------
>
>                 Key: SHRINKWRAP-261
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-261
>             Project: ShrinkWrap
>          Issue Type: Feature Request
>          Components: ext-resolver
>    Affects Versions: 1.0.0-alpha-12
>            Reporter: Nicklas Karlsson
>            Assignee: Samuel Santos
>            Priority: Minor
>
> It would be handy to have a shortcut for including maven artifacts, something along the lines of 
> MavenArtifact.resolve(Coordinate.of("joda-time", "joda-time", "1.6")).as(GenericArchive.class) or 
> MavenArtifact.resolve("joda-time:joda-time:1.6").as(GenericArchive.class) or
> Maven.artifact("joda-time:joda-time:1.6")

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira