[shrinkwrap-issues] [JBoss JIRA] (SHRINKWRAP-265) MavenDependencyResolver.resolveAs is misleading

[Samuel Santos (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKWRAP-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636722#comment-12636722 ] 

Samuel Santos commented on SHRINKWRAP-265:
------------------------------------------

Hi Karel,

Should we go ahead and implement something like what we discuss here http://community.jboss.org/message/602026#602026?

{code}
// Depending on the strategy used, may return "<T extends Archive<T>> Collection<T>" or "<T extends Archive<T>> T"
MavenDependencyResolver.artifact("foo:bar:1").strategy(TransitiveDependencyResolver.class).resolveAs(T type [, MavenResolutionFilter filter]);
{code}
                
> MavenDependencyResolver.resolveAs is misleading
> -----------------------------------------------
>
>                 Key: SHRINKWRAP-265
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-265
>             Project: ShrinkWrap
>          Issue Type: Task
>          Components: ext-resolver
>    Affects Versions: 1.0.0-alpha-12
>            Reporter: Samuel Santos
>            Assignee: Samuel Santos
>
> The method name {{resolveAs}} is misleading as it does not imply any dependencies.
> We should refactor it into two distinct methods:
> {code}
> <T extends Archive<T>> Collection<T> MavenDependencyResolver.resolveWithDependenciesAs(T type); // return the Maven artifact and its dependencies
> <T extends Archive<T>> T MavenDependencyResolver.resolveAs(T type); // return the artifact without any dependencies
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira