[shrinkwrap-issues] [JBoss JIRA] Issue Comment Edited: (SHRINKDESC-68) Improve code coverage for SPI module

[Bartosz Majsak (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKDESC-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626997#comment-12626997 ] 

Bartosz Majsak edited comment on SHRINKDESC-68 at 9/7/11 5:54 PM:
------------------------------------------------------------------

EclEmma reports 73.3% now (but somehow it's not giving right coverage for enums). Cobertura reports above 80%. But what matters more than numbers - I caught two more bugs and covered them by tests.

Things skipped in linked pull request are Importers/Exporters. Should I cover them as well?

BTW - How about adding this stuff to the build (and CI), if it's not there already? Maybe also checkstyle/findbugs/pmd? I have some liberal rules already prepared from different projects.

      was (Author: bmajsak):
    EclEmma reports 73.3% now (but somehow it's not giving right coverage for enums). But what matters more than numbers - I caught two more bugs and covered them by tests.

Things skipped in linked pull request are Importers/Exporters. Should I cover them as well?
  
> Improve code coverage for SPI module
> ------------------------------------
>
>                 Key: SHRINKDESC-68
>                 URL: https://issues.jboss.org/browse/SHRINKDESC-68
>             Project: ShrinkWrap Descriptors
>          Issue Type: Task
>            Reporter: Tommy Tynjä
>            Assignee: Bartosz Majsak
>
> We need to assure that the test coverage of the SPI module is sufficent. Generally, a code coverage of 80% is considered an adequate amount, so that should be considered the minimum acceptable threshold.
> As this is a general issue it can be added with subtasks for specific parts of the SPI if needed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira