[shrinkwrap-issues] [JBoss JIRA] Resolved: (SHRINKWRAP-335) Classes from the Bootstrap CL can not be added to ClassContainers

[Andrew Rubinger (JIRA)]

     [ https://issues.jboss.org/browse/SHRINKWRAP-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Rubinger resolved SHRINKWRAP-335.
----------------------------------------

    Resolution: Done


Upstream: https://github.com/shrinkwrap/shrinkwrap/commit/437ab0e41d3d69ff9a1ebb5e9d1ed7bdff3cdbc1

> Classes from the Bootstrap CL can not be added to ClassContainers
> -----------------------------------------------------------------
>
>                 Key: SHRINKWRAP-335
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-335
>             Project: ShrinkWrap
>          Issue Type: Bug
>          Components: impl-base
>    Affects Versions: 1.0.0-beta-5
>            Reporter: Andrew Rubinger
>            Assignee: Andrew Rubinger
>            Priority: Critical
>             Fix For: 1.0.0-beta-6
>
>
> This is failing: 
> {code}   /**
>     * Ensure classes from the Bootstrap CL 
>     * can be added to {@link ClassContainer}s.
>     * 
>     * @throws Exception
>     */
>    @Test
>    @ArchiveType(ClassContainer.class)
>    public void testAddClassFromBootstrapCl() throws Exception
>    {
>       final ClassContainer<T> archive = this.getClassContainer();
>       archive.addClass(String.class);
>       Assert.assertTrue("Archive does not contain class added from bootstrap CL",
>             ((Archive<?>) archive).contains("/java/lang/String.class"));
>    }{code}
> ...with:
> {code}java.lang.IllegalArgumentException: ClassLoader must be specified
> 	at org.jboss.shrinkwrap.impl.base.Validate.notNull(Validate.java:44)
> 	at org.jboss.shrinkwrap.impl.base.URLPackageScanner.newInstance(URLPackageScanner.java:77)
> 	at org.jboss.shrinkwrap.impl.base.container.ContainerBase.addPackage(ContainerBase.java:1328)
> 	at org.jboss.shrinkwrap.impl.base.container.ContainerBase.addPackages(ContainerBase.java:1303)
> 	at org.jboss.shrinkwrap.impl.base.container.ContainerBase.addClasses(ContainerBase.java:1167)
> 	at org.jboss.shrinkwrap.impl.base.container.ContainerBase.addClass(ContainerBase.java:1090)
> 	at org.jboss.shrinkwrap.impl.base.test.DynamicContainerTestBase.testAddClassFromBootstrapCl(DynamicContainerTestBase.java:923)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:616)
> 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
> 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
> 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
> 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
> 	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
> 	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49)
> 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
> 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
> 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
> 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
> 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
> 	at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
> 	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)
> 	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
> 	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
> 	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
> 	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
> 	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira