[shrinkwrap-issues] [JBoss JIRA] (SHRINKDESC-113) Move DescriptorNamespace out of the Public API

[Andrew Rubinger (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKDESC-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688632#comment-12688632 ] 

Andrew Rubinger commented on SHRINKDESC-113:
--------------------------------------------

Perhaps instead of "Freezing" the namespaces we instead allow them to be mutable only in the Descriptor mutable view?
                
> Move DescriptorNamespace out of the Public API
> ----------------------------------------------
>
>                 Key: SHRINKDESC-113
>                 URL: https://issues.jboss.org/browse/SHRINKDESC-113
>             Project: ShrinkWrap Descriptors
>          Issue Type: Task
>            Reporter: Andrew Rubinger
>            Assignee: Andrew Rubinger
>
> This needs some discussion before being done.  It'd break backwards-compatibility with the 1.x series.
> DescriptorNamespace is mutable, which conflicts with the goals outlined in SHRINKDESC-21.  We're not really testing its direct usage at the moment, and I wonder what reason end-users would have to be invoking its operations to muck around with the "namespace" of a domain object.  Currently all descriptors are supporting its operations by extension:
> {code}public interface WebAppDescriptor extends Descriptor, DescriptorNamespace<WebAppDescriptor>{code}
> ...and the methods in question as defined by DescriptorNamespace are:
> {code}
>    public T addDefaultNamespaces();
>    public T addNamespace(String name, String value);
>    public List<String> getNamespaces();
>    public T removeAllNamespaces();{code}
> Note that Ralf's work in SHRINKDESC-21 also splits this into DescriptorNamespace and DescriptorMutableNamespace.
> My feeling is that neither should be part of the API; maybe SPI or just internals.
> Discuss if it's appropriate to remove this and break the backwards-compatibility with the 1.x series.  In this case, I'm willing to entertain this exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira