[shrinkwrap-issues] [JBoss JIRA] (SHRINKWRAP-402) Support method for checking what type of Archive this is
Aslak Knutsen (JIRA)
jira-events at lists.jboss.org
Mon Sep 10 06:21:33 EDT 2012
[ https://issues.jboss.org/browse/SHRINKWRAP-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716919#comment-12716919 ]
Aslak Knutsen commented on SHRINKWRAP-402:
------------------------------------------
> If all other deployment mechanisms in AS7, GlassFish, etc, handle flat-file deployments by appropriately inspecting name and contents, why does Arquillian need this support from ShrinkWrap
That's just a silly comparison. Non of those use ShrinkWrap for their deployment chain, Arquillian does.
And no Arquillian doesn't _need_ it from ShrinkWrap. It just sounds like a reasonable thing for ShrinkWrap to provide, given it's the entry point for Deployment creation.
> Support method for checking what type of Archive this is
> --------------------------------------------------------
>
> Key: SHRINKWRAP-402
> URL: https://issues.jboss.org/browse/SHRINKWRAP-402
> Project: ShrinkWrap
> Issue Type: Feature Request
> Components: api, impl-base
> Affects Versions: 1.0.0
> Reporter: Aslak Knutsen
> Assignee: Aslak Knutsen
>
> ShrinkWrap has the notion of views to wrap a Archive. While a view can be anything, some of the views describes types of Archives, e.g. WebArchive. A Archive should be able to tell which type it is. Even tho the content structure to some extent define the type, external sources like a Container will determine the type of the Archive soley on the archive name extension.
> {code}
> ShrinkWrap.create(JavaArchive.class).isOfType(WebArchive.class) == false
> ShrinkWrap.create(JavaArchive.class, "my.war").isOfType(WebArchive.class) == true
> ShrinkWrap.create(MySpecialWebArchive.class, "my.war").isOfType(WebArchive.class) == true
> {code}
> A simple check if the current archive name ends with the Types defined extension mapping should work in most cases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the shrinkwrap-issues
mailing list